Code style updates #251
Merged
Code style updates #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- black formatting - minor refactoring to use utils function where useful - remove check for installation of OpenVINO 2021.4 from some notebooks (is assumed now) - added parameters to many function calls - modified some descriptions and headers for clarification and consistency - added semicolons after plt.imshow() calls to prevent printing matplotlib axis info Not intended to be complete - incremental improvements
ryanloney
reviewed
Sep 11, 2021
| @@ -2,13 +2,16 @@ | |||
| "cells": [ | |||
| { | |||
| "cell_type": "markdown", | |||
| "id": "b875b31c", | |||
There was a problem hiding this comment.
@helena-intel just curious, but why do these ids show up now? Do we use them for something?
There was a problem hiding this comment.
This is a change in the notebook format. This is not the best link but gives some info and issues jupyterlab/jupyterlab#9729 (comment)
ryanloney
approved these changes
Sep 11, 2021
Thanks for trying them all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/path/to/model_optimizerwithmoNot intended to be complete - incremental improvements
More readable diff attached as PDF (created with nbdime and ansi2html)
diff.pdf