110: Replace MO CLI with Python API and use PTQ nncf API #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aleksandr-mokrov
commented
Mar 29, 2023
•
aleksandr-mokrov
commented
- MO CLI is replaced with Python API
- POT is replaced with PTQ nncf API.
- 110-ct-segmentation-quantize.ipynb is removed. Only 110-ct-segmentation-quantize-nncf.ipynb is actual.
- pytorch-monai-training.ipynb is updated: PyTorch Lightning has new incompatible interface (Remove memory-retaining epoch-end hooks Lightning-AI/pytorch-lightning#16520 for example), F1 score metric from POT replaced by BinaryF1Score from torchmetrics.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
eaidova
reviewed
Apr 3, 2023
notebooks/110-ct-segmentation-quantize/110-ct-segmentation-quantize-nncf.ipynb
Show resolved
Hide resolved
eaidova
reviewed
Apr 3, 2023
notebooks/110-ct-segmentation-quantize/110-ct-segmentation-quantize-nncf.ipynb
Outdated
Show resolved
Hide resolved
… Usage of pytorch-lightning is changed due to new incompatible interface. 110-ct-segmentation-quantize.ipynb is deleted as outdated (replaced by 110-ct-segmentation-quantize-nncf.ipynb).
aleksandr-mokrov
changed the title
eaidova
reviewed
Apr 5, 2023
| @@ -28,7 +28,7 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Line #2. NIFTI_PATH = Path("~/PycharmProjects/default/kits19/data").expanduser()
please restore path
Reply via ReviewNB
|
@aleksandr-mokrov you have merge conflict, could you please resolve it? |
# Conflicts: # notebooks/110-ct-segmentation-quantize/110-ct-segmentation-quantize.ipynb
@aleksandr-mokrov please remove unused imports |
Ravindu987
pushed a commit
to Ravindu987/openvino_notebooks
that referenced
this pull request
Apr 14, 2023
…lkit#965) * Removing yaspin from dependencies * F1 score metric from POT replaced by BinaryF1Score from torchmetrics. Usage of pytorch-lightning is changed due to new incompatible interface. 110-ct-segmentation-quantize.ipynb is deleted as outdated (replaced by 110-ct-segmentation-quantize-nncf.ipynb). * Improved description * Keep previous configuration * Return max_epochs to 1 if CPU * Return the default path. * Unused import is removed * Unused import is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.