Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add Semi-SL multilabel classification algorithm #1805

Merged
merged 22 commits into from
Mar 16, 2023
Merged

[FEATURE] Add Semi-SL multilabel classification algorithm #1805

merged 22 commits into from
Mar 16, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Feb 22, 2023 •
edited

  • SemiSL for multilabel classification with BT loss and adaptive loss weighting
  • Docs
  • CLI test
  • Unit test

Future work:

  • Add SemiSL to regression tests

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI labels Feb 22, 2023
@sovrasov sovrasov changed the title Add Semi-SL multilabel [FEATURE] Add Semi-SL multilabel classification algorithm Feb 22, 2023
@sovrasov sovrasov force-pushed the vs/multilabel_semi_sl branch 2 times, most recently from c09a514 to 6c06b9a Compare February 23, 2023 13:42
@github-actions github-actions bot added the TEST Any changes in tests label Mar 6, 2023
@sovrasov sovrasov added this to the 1.1.0 milestone Mar 9, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Mar 13, 2023
@github-actions github-actions bot added DOC Improvements or additions to documentation and removed DOC Improvements or additions to documentation labels Mar 13, 2023
@sovrasov sovrasov marked this pull request as ready for review March 13, 2023 23:45
@sovrasov sovrasov requested a review from a team as a code owner March 13, 2023 23:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited

Codecov Report

Patch coverage: 91.07% and project coverage change: +0.07 🎉

Comparison is base (6a3349b) 80.66% compared to head (56d22b9) 80.73%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1805      +/-   ##
===========================================
+ Coverage    80.66%   80.73%   +0.07%     
===========================================
  Files          486      488       +2     
  Lines        33249    33361     +112     
===========================================
+ Hits         26819    26934     +115     
+ Misses        6430     6427       -3
Impacted Files Coverage Δ
otx/cli/manager/config_manager.py 84.98% <ø> (ø)
...modules/models/heads/semisl_multilabel_cls_head.py 90.90% <90.90%> (ø)
...models/classifiers/semisl_multilabel_classifier.py 91.66% <91.66%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sungmanc
sungmanc previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kprokofi
kprokofi reviewed Mar 15, 2023
View reviewed changes
otx/mpa/modules/models/classifiers/semisl_multilabel_classifier.py Show resolved Hide resolved
otx/mpa/modules/models/heads/semisl_multilabel_cls_head.py Outdated Show resolved Hide resolved
otx/mpa/modules/models/heads/semisl_multilabel_cls_head.py Show resolved Hide resolved
otx/mpa/modules/models/heads/semisl_multilabel_cls_head.py Outdated Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Outdated Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Outdated Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Outdated Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Outdated Show resolved Hide resolved
docs/source/guide/explanation/algorithms/classification/multi_label_classification.rst Outdated Show resolved Hide resolved
sovrasov and others added 20 commits March 16, 2023 06:48
harimkang
harimkang approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great work!
The only thing I would say is that the E2E test is missing. Other than that, I have no comments.

kprokofi
kprokofi approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@kprokofi kprokofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kprokofi kprokofi merged commit 21aeb8d into develop Mar 16, 2023
@kprokofi kprokofi deleted the vs/multilabel_semi_sl branch March 16, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harimkang harimkang harimkang approved these changes

@kprokofi kprokofi kprokofi approved these changes

@JihwanEom JihwanEom JihwanEom approved these changes

@sungmanc sungmanc sungmanc left review comments

@goodsong81 goodsong81 Awaiting requested review from goodsong81 goodsong81 is a code owner

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sovrasov @codecov-commenter @harimkang @kprokofi @JihwanEom @sungmanc