Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct annotation argument (--train/val-ann-files) #1921

Merged
merged 19 commits into from
Apr 27, 2023

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Mar 21, 2023

Summary

  • Support direct annotation input for CoCo
    For now, we can use --train/val-ann-files argument

  • Support unlabeled file list argument

  • Add unit-tests for both functionalities

  • Unifying the data_root + data_roots --> data_roots

  • Edit the CHANGELOG

  • Edit the documents
    image

  • Add unlabeled example assets

  • Add subset annotation example assets

How to test

[To check the direct annotation functionality (Dataset Adapter)]
[To check the unlabeled file functionality]

  • tox -e pre-merge-all-py310 -- tests/unit/core/data/adapter/test_init.py

[To check the direct annotation functionality (Datumaro function itself)]

  • tox -e pre-merge-all-py310 -- tests/unit/core/data/manager/test_dataset_manager.py

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@github-actions github-actions bot added CLI Any changes in OTE CLI TEST Any changes in tests labels Mar 21, 2023
@yunchu
Copy link
Contributor

yunchu commented Apr 4, 2023

please add label for this PR.

@sungmanc sungmanc added the ALGO Any changes in OTX Algo Tasks implementation label Apr 4, 2023
@github-actions github-actions bot removed the ALGO Any changes in OTX Algo Tasks implementation label Apr 24, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 24, 2023
@sungmanc sungmanc added the ENHANCE Enhancement of existing features label Apr 25, 2023
@sungmanc sungmanc added this to the 1.3.0 milestone Apr 25, 2023
@sungmanc sungmanc added FEATURE New feature & functionality and removed ENHANCE Enhancement of existing features labels Apr 25, 2023
@sungmanc sungmanc marked this pull request as ready for review April 26, 2023 02:08
@sungmanc sungmanc requested a review from a team as a code owner April 26, 2023 02:08
@sungmanc sungmanc changed the title Support direct annotation Support direct annotation argument (--train/val-ann-files) Apr 26, 2023
harimkang
harimkang previously approved these changes Apr 26, 2023
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

otx/cli/manager/config_manager.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cih9088 cih9088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that --{subset}--data-roots and --{subset}-ann-files arguments have descriptions saying one can pass comma separated list of paths but it certainly does not support it.

It would be better to rename the plural to singular and modify the description or implement the comma separated list of paths feature.

otx/core/data/adapter/base_dataset_adapter.py Outdated Show resolved Hide resolved
otx/core/data/adapter/base_dataset_adapter.py Outdated Show resolved Hide resolved
otx/core/data/adapter/base_dataset_adapter.py Outdated Show resolved Hide resolved
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
sungmanc and others added 3 commits April 26, 2023 13:52
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
@sungmanc
Copy link
Contributor Author

I noticed that --{subset}--data-roots and --{subset}-ann-files arguments have descriptions saying one can pass comma separated list of paths but it certainly does not support it.

It would be better to rename the plural to singular and modify the description or implement the comma separated list of paths feature.

Agree, then could I change all variable and description at next PR?

cih9088
cih9088 previously approved these changes Apr 26, 2023
@sungmanc sungmanc enabled auto-merge (squash) April 26, 2023 09:10
@sungmanc sungmanc merged commit 93d6cc8 into openvinotoolkit:develop Apr 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Any changes in OTE CLI DOC Improvements or additions to documentation FEATURE New feature & functionality TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants