-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support direct annotation argument (--train/val-ann-files) #1921
Support direct annotation argument (--train/val-ann-files) #1921
Conversation
…_extensions into support-direct-ann
…_extensions into support-direct-ann
…_extensions into support-direct-ann
please add label for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that --{subset}--data-roots
and --{subset}-ann-files
arguments have descriptions saying one can pass comma separated list of paths but it certainly does not support it.
It would be better to rename the plural to singular and modify the description or implement the comma separated list of paths feature.
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Agree, then could I change all variable and description at next PR? |
Summary
Support direct annotation input for CoCo
For now, we can use
--train/val-ann-files
argumentSupport unlabeled file list argument
Add unit-tests for both functionalities
Unifying the
data_root
+data_roots
-->data_roots
Edit the CHANGELOG
Edit the documents
Add unlabeled example assets
Add subset annotation example assets
How to test
[To check the direct annotation functionality (Dataset Adapter)]
[To check the unlabeled file functionality]
[To check the direct annotation functionality (Datumaro function itself)]
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.