Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: enabling lr scale during distributed training #2254

Merged
merged 6 commits into from
Jun 21, 2023
Merged

bugfix: enabling lr scale during distributed training #2254

merged 6 commits into from
Jun 21, 2023

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Jun 20, 2023 •
edited

Summary

  • Current OTX doesn't scale learning rate when multi GPU training. Fix it to scale lr.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Jun 20, 2023
@eunwoosh eunwoosh added this to the 1.4.0 milestone Jun 20, 2023
@eunwoosh eunwoosh added the FIX defect fix label Jun 20, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jun 20, 2023
@eunwoosh eunwoosh marked this pull request as ready for review June 20, 2023 06:59
@eunwoosh eunwoosh requested a review from a team as a code owner June 20, 2023 06:59
sungmanc
sungmanc reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, w/ minor comments for the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
@eunwoosh @sungmanc
Update CHANGELOG.md
2ec51a7 
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
sungmanc
sungmanc previously approved these changes Jun 20, 2023
View reviewed changes
@eunwoosh eunwoosh marked this pull request as draft June 21, 2023 01:12
@eunwoosh eunwoosh marked this pull request as ready for review June 21, 2023 01:21
jaegukhyun
jaegukhyun requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add unit test for action task?

@eunwoosh
Copy link
Contributor Author

Could you add unit test for action task?

Sure, I implemented it.

@sungmanc sungmanc enabled auto-merge (squash) June 21, 2023 09:44
@sungmanc sungmanc merged commit 5da4646 into openvinotoolkit:develop Jun 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@jaegukhyun jaegukhyun jaegukhyun approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation FIX defect fix TEST Any changes in tests
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eunwoosh @sungmanc @jaegukhyun