Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'None' node issue in label schema mapping in case of label deletion #2300

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix 'None' node issue in label schema mapping in case of label deletion #2300

merged 1 commit into from
Jul 6, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Jul 5, 2023 •
edited

Summary

  • Workaround for None node or edge resulted from label deletion
  • Unit test to cover the situation

How to test

  • Unit test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81
Fix 'None' node issue in label schema mapping in case of label deletion
8a6407a 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@github-actions github-actions bot added API Any changes in OTX API TEST Any changes in tests labels Jul 5, 2023
sungmanc
sungmanc approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

tests/unit/api/serialization/test_label_mapper.py Show resolved Hide resolved
@sungmanc sungmanc modified the milestone: 1.2.4 Jul 6, 2023
@goodsong81 goodsong81 marked this pull request as ready for review July 6, 2023 02:09
@goodsong81 goodsong81 requested a review from a team as a code owner July 6, 2023 02:09
jaegukhyun
jaegukhyun approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check this on Geti side?

@goodsong81
Copy link
Contributor Author

Should we check this on Geti side?

Andru will help us :)

@goodsong81 goodsong81 merged commit 4fc2e8d into openvinotoolkit:releases/1.2.3 Jul 6, 2023
12 checks passed
@goodsong81 goodsong81 mentioned this pull request Jul 6, 2023
Merged
8 tasks
@goodsong81 goodsong81 deleted the fix_label_map_rel branch October 19, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@jaegukhyun jaegukhyun jaegukhyun approved these changes

Assignees
No one assigned
Labels
API Any changes in OTX API FIX defect fix HOTFIX RELEASE TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goodsong81 @sungmanc @jaegukhyun