Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResNeXt101-ATSS as a Experimental model #2309

Merged
merged 9 commits into from
Jul 7, 2023
Merged

Add ResNeXt101-ATSS as a Experimental model #2309

merged 9 commits into from
Jul 7, 2023

Conversation

jaegukhyun
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@jaegukhyun jaegukhyun added this to the 1.4.0 milestone Jul 6, 2023
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Jul 6, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review July 7, 2023 03:55
@jaegukhyun jaegukhyun requested a review from a team as a code owner July 7, 2023 03:55
eunwoosh
eunwoosh reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left one minor question. please take a look.

src/otx/algorithms/detection/configs/detection/resnext101_atss/template_experimental.yaml Outdated Show resolved Hide resolved
sungmanc
sungmanc previously approved these changes Jul 7, 2023
View reviewed changes
eunwoosh
eunwoosh previously approved these changes Jul 7, 2023
View reviewed changes
sungmanc
sungmanc previously approved these changes Jul 7, 2023
View reviewed changes
eunwoosh
eunwoosh previously approved these changes Jul 7, 2023
View reviewed changes
@jaegukhyun jaegukhyun dismissed stale reviews from eunwoosh and sungmanc via 8da981b July 7, 2023 07:15
@jaegukhyun jaegukhyun enabled auto-merge (squash) July 7, 2023 07:39
@jaegukhyun jaegukhyun merged commit 3a512dc into openvinotoolkit:develop Jul 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@eunwoosh eunwoosh eunwoosh approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaegukhyun @sungmanc @eunwoosh