Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve label deletion issue #2315

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Jul 6, 2023

Summary

If user add/delete the label, the circumstances below could be happen.

  • Multi-class --> Multi-class
  • Multi-class --> Multi-label
  • Multi-class --> H-label
  • Multi-label --> Multi-class
  • Multi-label --> Multi-label
  • Multi-label --> H-label
  • H-label --> Multi-class
  • H-label --> Multi-label
  • H-label --> H-label

To consider the above cases, I edited the test datasets and added integration tests to check the class decremental case (label deletion). It is not perfect and I don't want to change many things since it is a quick workaround.

image

Need more precise test cases to consider the label deletion, for further use.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungmanc sungmanc added TEST Any changes in tests FIX defect fix RELEASE labels Jul 6, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 6, 2023
@sungmanc sungmanc marked this pull request as ready for review July 7, 2023 01:04
@sungmanc sungmanc requested a review from a team as a code owner July 7, 2023 01:04
@sungmanc sungmanc marked this pull request as draft July 7, 2023 01:11
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Doesn't this change also have to apply to other versions?

@goodsong81 goodsong81 added this to the 1.2.4 milestone Jul 7, 2023
@sungmanc sungmanc marked this pull request as ready for review July 10, 2023 04:11
@sungmanc sungmanc requested review from a team and eunwoosh July 10, 2023 04:13
@yunchu yunchu merged commit 645cf7b into openvinotoolkit:releases/1.2.4 Jul 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix RELEASE TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants