-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve label deletion issue #2315
Merged
yunchu
merged 9 commits into
openvinotoolkit:releases/1.2.4
from
sungmanc:fix-label-deletion
Jul 10, 2023
Merged
Resolve label deletion issue #2315
yunchu
merged 9 commits into
openvinotoolkit:releases/1.2.4
from
sungmanc:fix-label-deletion
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunwoosh
reviewed
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Doesn't this change also have to apply to other versions?
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
…raining_extensions into fix-label-deletion
…ning_extensions into fix-label-deletion
goodsong81
approved these changes
Jul 10, 2023
eunwoosh
approved these changes
Jul 10, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If user add/delete the label, the circumstances below could be happen.
To consider the above cases, I edited the test datasets and added integration tests to check the class decremental case (label deletion). It is not perfect and I don't want to change many things since it is a quick workaround.
Need more precise test cases to consider the label deletion, for further use.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.