Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that engine.test doesn't work with XPU #3293

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Apr 9, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the OTX 2.0 For OTX v2.0 label Apr 9, 2024
chuneuny-emily
chuneuny-emily previously approved these changes Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.07%. Comparing base (17efd68) to head (f6c279f).

❗ Current head f6c279f differs from pull request most recent head 2f782d3. Consider uploading reports for the commit 2f782d3 to get more accurate results

Files Patch % Lines
src/otx/algo/strategies/xpu_single.py 71.42% 2 Missing ⚠️
src/otx/engine/engine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/2.0.0    #3293      +/-   ##
==================================================
- Coverage           80.08%   80.07%   -0.01%     
==================================================
  Files                 186      186              
  Lines               15413    15416       +3     
==================================================
+ Hits                12344    12345       +1     
- Misses               3069     3071       +2     
Flag Coverage Δ
py310 80.07% <62.50%> (-0.01%) ⬇️
py311 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eunwoosh eunwoosh merged commit c1e5187 into openvinotoolkit:releases/2.0.0 Apr 11, 2024
13 checks passed
kprokofi pushed a commit that referenced this pull request Apr 12, 2024
* fix bug

* align with pre-commit

---------

Co-authored-by: Emily <emily.chun@intel.com>
kprokofi added a commit that referenced this pull request Apr 16, 2024
* Enable training on XPU devices in OTX2.0 (#3094)

* add raising an error when metric is None

* added accelerators

* fix packages

* fix assigning model

* debug on MAX

* change precision

* update MixedPrecisionXPUPlugin

* debug

* added monkey patching

* minor

* minor

* added patch for mmengine

* fix OD and IS

* benchmark debug

* change device

* quick fix for instance seg

* fix pre-commit

* fix pre-commit

* clean the code

* added additional flag for mmcv

* added unit tests

* fixed unit test

* fix linter

* added unit tests and replied comments

* fix pre-commit

* minor fix

* added documentation

* fix unit test

* add workaround for semantic segmentation

* remove RoiAlignTest due to unstability

* minor

* remove strategy back

* try to patch SingleDeviceStrategy

* added auto xpu configuration

* patch strategy

* small fix

* reply to comments

* move patching xpu packages to accelerator

* fix test_xpu test

* remove do-not-install-mmcv

* fix pre-commit

* remove torch.xpu.optimize for segmentation

---------

Co-authored-by: Emily <emily.chun@intel.com>

* Add exporter/demo unit tests (#3218)

* added unit tests. Need to clean up

* move tests

* fix pre-commit

* return demo back

* minor

* delete unnecessery comments

* fix unit test

* fix pre-commit

* fix pre-commit 2

* fix test_postprocess_openvino_model

* fix unit tests

* test_precommit

* Fix a bug that engine.test doesn't work with XPU (#3293)

* fix bug

* align with pre-commit

---------

Co-authored-by: Emily <emily.chun@intel.com>

* fix merge conflicts for pre-commit

* fix precommit 2

* fix unit test

* fix pre-commit

* fix export tests

* fix pre-commit

* fix tox

* fix pre-commit

---------

Co-authored-by: Emily <emily.chun@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTX 2.0 For OTX v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants