Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.1] Explicitly cast incorrect output type in OV model #3395

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

sovrasov
Copy link
Contributor

Summary

This workarounds incorrect type of "labels" output in detection models on XPU

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.72%. Comparing base (6d5cf9c) to head (db20829).

Files Patch % Lines
src/otx/algorithms/common/utils/ir.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.0    #3395      +/-   ##
==================================================
- Coverage           80.73%   80.72%   -0.01%     
==================================================
  Files                 536      536              
  Lines               40491    40500       +9     
==================================================
+ Hits                32691    32695       +4     
- Misses               7800     7805       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov sovrasov marked this pull request as ready for review April 24, 2024 17:18
@sovrasov sovrasov requested a review from a team as a code owner April 24, 2024 17:18
@github-actions github-actions bot added the TEST Any changes in tests label Apr 24, 2024
@chuneuny-emily
Copy link
Contributor

@sovrasov - Can you fix the failing issue?

@sovrasov sovrasov added this to the 1.6.1 milestone Apr 25, 2024
@sovrasov
Copy link
Contributor Author

@sovrasov - Can you fix the failing issue?

I'll restart the CI, there's an instability in the runner

@sovrasov sovrasov enabled auto-merge (squash) April 25, 2024 13:08
@sovrasov sovrasov merged commit 54cfb4c into releases/1.6.0 Apr 25, 2024
16 of 17 checks passed
@sovrasov sovrasov deleted the vs/workaround_xpu_fp_labels branch April 25, 2024 13:13
@yunchu
Copy link
Contributor

yunchu commented Apr 26, 2024

@sovrasov please don't forget to update changelog.md for your change.
@eunwoosh @kprokofi please don't forget to check whether changelog.md are updated as reviewer especially the target branch is release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants