Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trivy worflow #3416

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Update trivy worflow #3416

merged 6 commits into from
Apr 30, 2024

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Apr 29, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@yunchu yunchu requested a review from a team as a code owner April 29, 2024 05:34
@github-actions github-actions bot added the BUILD label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (467208a) to head (fecea92).

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.6.0    #3416   +/-   ##
===============================================
  Coverage           80.71%   80.72%           
===============================================
  Files                 536      536           
  Lines               40500    40500           
===============================================
+ Hits                32691    32692    +1     
+ Misses               7809     7808    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eunwoosh
eunwoosh previously approved these changes Apr 29, 2024
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason why executing trivy twice to execute it with different trivy config?

@yunchu
Copy link
Contributor Author

yunchu commented Apr 30, 2024

Is the reason why executing trivy twice to execute it with different trivy config?

we need to have vulnerability scanning results from the dependencies as well as spdx.json formatted dependencies list but trivy cannot generate them at the same time. that's the reason why we need to run it twice. :)

@chuneuny-emily chuneuny-emily merged commit 2a8b0f1 into releases/1.6.0 Apr 30, 2024
18 checks passed
@chuneuny-emily chuneuny-emily deleted the infra/update-trivy branch April 30, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants