Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_from_checkpoint args to apply original model's hparams #3611

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Jun 12, 2024

Summary

Apply #3607 to other functions

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the OTX 2.0 For OTX v2.0 label Jun 12, 2024
@sungchul2 sungchul2 changed the title Apply https://github.com/openvinotoolkit/training_extensions/pull/3607 to other functions Fix load_from_checkpoint args to apply original model's hparams Jun 12, 2024
src/otx/engine/engine.py Outdated Show resolved Hide resolved
@sungchul2 sungchul2 requested a review from harimkang June 12, 2024 06:30
harimkang
harimkang previously approved these changes Jun 12, 2024
@github-actions github-actions bot added the TEST Any changes in tests label Jun 12, 2024
@sungchul2 sungchul2 enabled auto-merge (squash) June 12, 2024 08:02
@sungchul2 sungchul2 merged commit 35cedb1 into openvinotoolkit:develop Jun 12, 2024
13 checks passed
@sungchul2 sungchul2 deleted the fix-load-from-checkpoint branch June 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTX 2.0 For OTX v2.0 TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants