forked from MoonInTheRiver/DiffSinger
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for some old features and behaviors #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # augmentation/spec_stretch.py # preprocessing/acoustic_binarizer.py
agentasteriski
added a commit
to agentasteriski/DiffSinger_colab_notebook_MLo7
that referenced
this pull request
Feb 27, 2024
No longer supported as of openvpi/DiffSinger#172 Raised config f0_max to 1600 to match existing binarizer edit use_melody_encoder now enables along with predict_pitch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed features and behaviors
Other changes
interp_uv
configuration is removed and forced toTrue
.train_set_name
andvalid_set_name
are removed and forced totrain
andvalid
.num_pad_tokens
is removed and forced to 1.ffn_padding
is removed and forced toSAME
.g2p_dictionary
configuration is removed in favor ofdictionary
.pndm_speedup
configuration is renamed todiff_speedup
.txt_embed
layer in FastSpeech2 encoder is removed.dictionary
,diff_accelerator
,f0_embed_type
,pe
,pndm_speedup
,use_key_shift_embed
,use_speed_embed
.