Mass prune #6
Mass prune #6
Conversation
|
Just pushed the obvious deletions to the UI. This code compiles. I will need more info on the procedure to test and run it. However the current state, should let you choose different MC options and attempt to run MC in real-time. I don't know if the actual MC correction will work fully through openvr. |
| SolutionGuid = {9465DA5B-21F6-46AA-8620-B7544DA98D0F} | ||
| Qt5Version = 5.13.0 |
There was a problem hiding this comment.
Had some issues when loading the project and it not seeing the Qt version. I had to use QT VS tools right click client_overlay project -> QT Project Settings -> set version, and select all necessary Qt modules before it would compile
| @@ -136,7 +128,6 @@ MyStackViewPage { | |||
| text: "Identify" | |||
| onClicked: { | |||
| if (deviceSelectionComboBox.currentIndex >= 0) { | |||
| DeviceManipulationTabController.triggerHapticPulse(deviceSelectionComboBox.currentIndex) | |||
There was a problem hiding this comment.
I removed features to anything sending triggerHaptic. It is mainly used by the UI to identify devices. However its rather buggy feature to force haptic feedback through openvr. There are other more stable ways to identify devices if that feature is needed. I think there are some new ways to identify devices built right into steamvr also.
| @@ -168,39 +159,11 @@ MyStackViewPage { | |||
| Layout.minimumWidth: 350 | |||
| Layout.preferredWidth: 400 | |||
| Layout.fillWidth: true | |||
| model: ["Default", "Disable", "Redirect to", "Swap with", "Motion Compensation"] | |||
| model: ["Default", "Motion Compensation"] | |||
There was a problem hiding this comment.
The deviceMode UI menu maps based on array index. Removing other options, and just leaving motion compensation. Move MC from 4 to 1. This maps to the TabControllers and all references to MC should be the 1 index. This should allow the UI to work all the way through the TabController to VRIE lib to the driver and finally into openvr...
|
I'm going to accept and merge this PR as the starting point, @Dschadu has continued work from this. |
Removed many features and code, Including:
I also updated ServerDriver and VirtualDeviceDriver to use the newer IVRDriverInput interface and all the necessary virtual function definitions.
There are still references to likely unneeded features for motion compensation. I also have not touched any of the UI layout so that likely will have undefined references. Many of the UI pages can be removed with only the motion compensation pages remaining.
This is just a checkpoint on the work. I probably can do more. However It would be nice to see once the UI compiles, if this pruned code still works to provide the previous motion compensation features required.