Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete snapshots - handle snapshot lookup and make it concurrent #2297

Open
JeffreyDevloo opened this issue May 8, 2019 · 2 comments
Open

Delete snapshots - handle snapshot lookup and make it concurrent #2297

JeffreyDevloo opened this issue May 8, 2019 · 2 comments
Labels
state_codecomplete type_enhancement

Comments

@JeffreyDevloo
Copy link
Contributor

  • Deleting a large number of snapshots sequentially is very slow. We can optimize it by working storagedriver based and launch multiple concurrent tasks this way
  • vdisk.snapshot_ids can throw errors if the volumedriver does not respond. This path is currently not caught and causes the whole task to bail out
@JeffreyDevloo
Copy link
Contributor Author

Will be implemented by #2298

@JeffreyDevloo
Copy link
Contributor Author

Framework concurrency added by #2298.
This implementation still iterates on the snapshots, causing a snapshot.xml update each time.

The volumedriver implemented a delete_snapshots call which can be used instead: https://github.com/openvstorage/volumedriver-ee/issues/207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state_codecomplete type_enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffreyDevloo @sjovdnbos