Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller role failed to be set in ovsdb #218

Closed
romanponczkowski opened this issue Jul 5, 2021 · 3 comments
Closed

controller role failed to be set in ovsdb #218

romanponczkowski opened this issue Jul 5, 2021 · 3 comments

Comments

@romanponczkowski
Copy link

Enviroment
openvswitch-2.15.90

Scenario:
controler (ONOS) connected to vswitch and set role to primary.

Observerd Issue:
Port statistics in ovsdb are no longer updated. in ovs-vswitchd.log every 5s appears warning:

2021-07-05T10:43:36.916Z|00037|connmgr|INFO|ETH1: added service controller "punix:/var/run/openvswitch/ETH1.mgmt"
2021-07-05T10:43:36.916Z|00038|rconn|INFO|ETH1<->tcp:172.20.0.2:6653: connecting...
2021-07-05T10:43:36.917Z|00039|connmgr|INFO|ETH1: added primary controller "tcp:172.20.0.2:6653"
2021-07-05T10:43:36.932Z|00040|bridge|INFO|ovs-vswitchd (Open vSwitch) 2.15.90
2021-07-05T10:43:36.932Z|00041|rconn|INFO|ETH1<->tcp:172.20.0.2:6653: connected
2021-07-05T10:43:41.933Z|00042|ovsdb_idl|WARN|transaction error: {"details":"primary is not one of the allowed values ([master, other, slave])","error":"constraint violation"}
2021-07-05T10:43:46.934Z|00043|memory|INFO|38956 kB peak resident set size after 10.1 seconds
2021-07-05T10:43:46.934Z|00044|memory|INFO|handlers:1 ofconns:1 ports:5 revalidators:1 rules:23 udpif keys:2
2021-07-05T10:43:46.935Z|00045|ovsdb_idl|WARN|transaction error: {"details":"primary is not one of the allowed values ([master, other, slave])","error":"constraint violation"}
2021-07-05T10:43:46.990Z|00046|connmgr|INFO|ETH1<->tcp:172.20.0.2:6653: 33 flow_mods in the 4 s starting 10 s ago (33 adds)
2021-07-05T10:43:51.936Z|00047|ovsdb_idl|WARN|transaction error: {"details":"primary is not one of the allowed values ([master, other, slave])","error":"constraint violation"}
2021-07-05T10:43:56.938Z|00048|ovsdb_idl|WARN|transaction error: {"details":"primary is not one of the allowed values ([master, other, slave])","error":"constraint violation"}
2021-07-05T10:44:01.939Z|00049|ovsdb_idl|WARN|transaction error: {"details":"primary is not one of the allowed values ([master, other, slave])","error":"constraint violation"}

It seems to be related with replacing master/slave terminology with primary/secondary.

@blp
Copy link

blp commented Jul 6, 2021

Thanks for the report. If you can, please try this patch: https://mail.openvswitch.org/pipermail/ovs-dev/2021-July/385117.html

ovsrobot pushed a commit to ovsrobot/ovs that referenced this issue Jul 6, 2021
The vswitchd database schema requires role names to be "master" or
"slave", but this code tried to use "primary" and "secondary".

Signed-off-by: Ben Pfaff <blp@ovn.org>
Reported-at: openvswitch/ovs-issues#218
Fixes: 807152a ("Use primary/secondary, not master/slave, as names for OpenFlow roles.")
Signed-off-by: 0-day Robot <robot@bytheb.org>
@romanponczkowski
Copy link
Author

I confirm, after applying this patch it works ok.

blp added a commit to openvswitch/ovs that referenced this issue Jul 7, 2021
The vswitchd database schema requires role names to be "master" or
"slave", but this code tried to use "primary" and "secondary".

Signed-off-by: Ben Pfaff <blp@ovn.org>
Reported-at: openvswitch/ovs-issues#218
Tested-at: openvswitch/ovs-issues#218 (comment)
Fixes: 807152a ("Use primary/secondary, not master/slave, as names for OpenFlow roles.")
blp added a commit to openvswitch/ovs that referenced this issue Jul 7, 2021
The vswitchd database schema requires role names to be "master" or
"slave", but this code tried to use "primary" and "secondary".

Signed-off-by: Ben Pfaff <blp@ovn.org>
Reported-at: openvswitch/ovs-issues#218
Tested-at: openvswitch/ovs-issues#218 (comment)
Fixes: 807152a ("Use primary/secondary, not master/slave, as names for OpenFlow roles.")
@blp
Copy link

blp commented Jul 7, 2021

Thanks, I applied this fix to master and branch-2.15.

@blp blp closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants