Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect assumption of the IRQL #47

Closed
svinturis opened this issue Oct 1, 2014 · 1 comment
Closed

Incorrect assumption of the IRQL #47

svinturis opened this issue Oct 1, 2014 · 1 comment
Assignees
@svinturis
Labels
enhancement
Milestone
P1

Comments

@svinturis
Copy link

Acquiring a spin lock raises the IRQL level to DISPATCH_LEVEL. But in many places of the code, while holding a spin lock, there are useless checks for the current IRQL against DISPATCH_LEVEL. Also, the dispatch flag is not correctly set when calling NdisAcquireRWLockXXX() functions, which causes an extra check of the current IRQL.
@svinturis svinturis self-assigned this Oct 1, 2014
@aserdean aserdean added this to the P1 milestone Oct 1, 2014
blp pushed a commit to openvswitch/ovs that referenced this issue Oct 6, 2014
@svinturis @blp
datapath-windows: Incorrect assumption of the IRQL
1ce4551 
Acquiring a spin lock raises the IRQL to DISPATCH_LEVEL. But
in many places of the code, while holding a spin lock, there
are useless checks for the current IRQL against DISPATCH_LEVEL.
Also, the dispatch flag is not correctly set when calling
NdisAcquireRWLockXXX() functions, which causes an extra check
of the current IRQL.

Signed-off-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-at: openvswitch/ovs-issues#47
Acked-by: Nithin Raju <nithin@vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
@svinturis
Copy link
Author

This issue is closed as it was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svinturis svinturis

Labels
enhancement
Projects
None yet
Milestone
P1
Development

No branches or pull requests
2 participants
@aserdean @svinturis