Skip to content

Commit

Permalink
ovn-controller: Only add comment in binding_cleanup() in case of chan…
Browse files Browse the repository at this point in the history
…ges.

This makes the comment more meaningful.

Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Mark Michelson <mmichels@redhat.com>
  • Loading branch information
blp committed Jun 15, 2018
1 parent 0035ab4 commit 235b571
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions ovn/controller/binding.c
Expand Up @@ -628,11 +628,6 @@ binding_cleanup(struct ovsdb_idl_txn *ovnsb_idl_txn,
return true;
}

ovsdb_idl_txn_add_comment(
ovnsb_idl_txn,
"ovn-controller: removing all port bindings for '%s'",
chassis_rec->name);

const struct sbrec_port_binding *binding_rec;
bool any_changes = false;
SBREC_PORT_BINDING_TABLE_FOR_EACH (binding_rec, port_binding_table) {
Expand All @@ -641,5 +636,13 @@ binding_cleanup(struct ovsdb_idl_txn *ovnsb_idl_txn,
any_changes = true;
}
}

if (any_changes) {
ovsdb_idl_txn_add_comment(
ovnsb_idl_txn,
"ovn-controller: removing all port bindings for '%s'",
chassis_rec->name);
}

return !any_changes;
}

0 comments on commit 235b571

Please sign in to comment.