Skip to content

Commit

Permalink
datapath-windows: Fix assertion in Netlink.c
Browse files Browse the repository at this point in the history
NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.

Signed-off-by: Ankur Sharma <ankursharma@vmware.com>
Acked-by: Nithin Raju <nithin@vmware.com>
Tested-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
  • Loading branch information
ankursh authored and blp committed Oct 13, 2014
1 parent c881751 commit 2aca218
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions datapath-windows/ovsext/Netlink/Netlink.c
Expand Up @@ -51,7 +51,7 @@ NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType,

/* To keep compiler happy for release build. */
UNREFERENCED_PARAMETER(offset);
ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _OVS_MESSAGE)) != 0);
ASSERT(NlBufAt(nlBuf, offset, 0) != 0);

msgOut.nlMsg.nlmsgType = nlmsgType;
msgOut.nlMsg.nlmsgFlags = nlmsgFlags;
Expand Down Expand Up @@ -88,7 +88,7 @@ NlFillNlHdr(PNL_BUFFER nlBuf, UINT16 nlmsgType,

/* To keep compiler happy for release build. */
UNREFERENCED_PARAMETER(offset);
ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _NL_MSG_HDR)) != 0);
ASSERT(NlBufAt(nlBuf, offset, 0) != 0);

msgOut.nlmsgType = nlmsgType;
msgOut.nlmsgFlags = nlmsgFlags;
Expand Down

0 comments on commit 2aca218

Please sign in to comment.