Skip to content

Commit

Permalink
ovs-ofctl: Fix coredump when using "add-groups" command.
Browse files Browse the repository at this point in the history
When using ovs-ofctl add-groups with only "switch" argument, a coredump
is generated.  The main reason is that the command "ovs-ofctl add-groups"
need two arguments but the limitation of min-args of this command is
set to 1.

Fixes: 7395c05 ("Implement OpenFlow 1.1+ "groups" protocol.")
Submitted-at: #360
Signed-off-by: Wang Yibo <bobxxwang@126.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
Wang Yibo authored and igsilya committed May 14, 2021
1 parent 8dacc52 commit 3800259
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utilities/ovs-ofctl.c
Expand Up @@ -5041,7 +5041,7 @@ static const struct ovs_cmdl_command all_commands[] = {
{ "add-group", "switch group",
1, 2, ofctl_add_group, OVS_RW },
{ "add-groups", "switch file",
1, 2, ofctl_add_groups, OVS_RW },
2, 2, ofctl_add_groups, OVS_RW },
{ "mod-group", "switch group",
1, 2, ofctl_mod_group, OVS_RW },
{ "del-groups", "switch [group]",
Expand Down

0 comments on commit 3800259

Please sign in to comment.