Skip to content

Commit

Permalink
ofproto-dpif: Fix memory leak in disable_datapath_clone()
Browse files Browse the repository at this point in the history
In testcase "ofproto-dpif - clone action", valgrind reports a memory leak
with the following call stack.
    xrealloc (util.c:123)
    ds_reserve (dynamic-string.c:63)
    ds_put_format_valist (dynamic-string.c:161)
    ds_put_format (dynamic-string.c:142)
    disable_datapath_clone (ofproto-dpif.c:5206)
    process_command (unixctl.c:313)
    run_connection (unixctl.c:347)
    unixctl_server_run (unixctl.c:400)
    main (ovs-vswitchd.c:112)

Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
  • Loading branch information
YiHungWei authored and blp committed Apr 24, 2017
1 parent 91e4f4d commit 391097b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ofproto/ofproto-dpif.c
Expand Up @@ -5257,6 +5257,7 @@ disable_datapath_clone(struct unixctl_conn *conn OVS_UNUSED,
udpif_flush(ofproto->backer->udpif);
ds_put_format(&ds, "Datapath clone action disabled for bridge %s", br);
unixctl_command_reply(conn, ds_cstr(&ds));
ds_destroy(&ds);
}

static void
Expand Down

0 comments on commit 391097b

Please sign in to comment.