Skip to content

Commit

Permalink
datapath-windows: Don't leak NBLs with multiple NBs.
Browse files Browse the repository at this point in the history
Currently, if we receive an NBL with multiple NBs from NDIS, we just
ASSERT() and not do anything. The right thing to do obviously is to
process the NBL. This is a work in progress.

In the meantime, we should complete the NBL and not just leak it.

Signed-off-by: Nithin Raju <nithin@vmware.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Tested-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
  • Loading branch information
nithinrajub authored and blp committed Oct 31, 2014
1 parent eb391b7 commit 3bfe44a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion datapath-windows/ovsext/PacketIO.c
Expand Up @@ -218,7 +218,12 @@ OvsStartNBLIngress(POVS_SWITCH_CONTEXT switchContext,
curNb = NET_BUFFER_LIST_FIRST_NB(curNbl);
if (curNb->Next != NULL) {
/* XXX: This case is not handled yet. */
ASSERT(FALSE);
RtlInitUnicodeString(&filterReason,
L"Dropping NBLs with multiple NBs");
OvsStartNBLIngressError(switchContext, curNbl,
sendCompleteFlags, &filterReason,
NDIS_STATUS_RESOURCES);
continue;
} else {
POVS_BUFFER_CONTEXT ctx;
OvsFlow *flow;
Expand Down

0 comments on commit 3bfe44a

Please sign in to comment.