Skip to content

Commit

Permalink
bond: Use correct type for slave's change_seq.
Browse files Browse the repository at this point in the history
seq values are 64-bit, and storing them to a 32-bit variable causes
the stored value never to match actual seq value after the seq value
gets big enough.

This is a likely cause of OVS main thread using 100% CPU in a system
using bonds after some runtime.

VMware-BZ: #1564993
Reported-by: Hiram Bayless <hbayless@vmware.com>
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
  • Loading branch information
jrajahalme committed Dec 4, 2015
1 parent 25bda26 commit 4b60a61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ofproto/bond.c
Expand Up @@ -83,7 +83,7 @@ struct bond_slave {
void *aux; /* Client-provided handle for this slave. */

struct netdev *netdev; /* Network device, owned by the client. */
unsigned int change_seq; /* Tracks changes in 'netdev'. */
uint64_t change_seq; /* Tracks changes in 'netdev'. */
ofp_port_t ofp_port; /* Open flow port number */
char *name; /* Name (a copy of netdev_get_name(netdev)). */

Expand Down

0 comments on commit 4b60a61

Please sign in to comment.