Skip to content

Commit

Permalink
packets: Fix using outdated RSS hash after MPLS decapsulation.
Browse files Browse the repository at this point in the history
When a packet is received, the RSS hash is calculated if it is not
already available. The Exact Match Cache (EMC) entry is then looked up
using this RSS hash.

When a MPLS encapsulated packet is received, the MPLS header is popped
and the packet is recirculated. Since the RSS hash has not been
invalidated here, the EMC lookup for all decapsulated packets will hit
the same entry even though these packets will have different tuple
values. This degrades performance severely as different inner packets
from the same MPLS tunnel would hit the same EMC entry.

This patch invalidates RSS hash (by resetting offload flags) after MPLS
header is popped.

Signed-off-by: Nitin Katiyar <nitin.katiyar@ericsson.com>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
  • Loading branch information
Nitin Katiyar authored and Alin Gabriel Serdean committed Jul 15, 2020
1 parent 3913c8e commit 5932f29
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/packets.c
Expand Up @@ -411,6 +411,10 @@ pop_mpls(struct dp_packet *packet, ovs_be16 ethtype)
/* Shift the l2 header forward. */
memmove((char*)dp_packet_data(packet) + MPLS_HLEN, dp_packet_data(packet), len);
dp_packet_resize_l2_5(packet, -MPLS_HLEN);

/* Invalidate offload flags as they are not valid after
* decapsulation of MPLS header. */
dp_packet_reset_offload(packet);
}
}

Expand Down

0 comments on commit 5932f29

Please sign in to comment.