Skip to content

Commit

Permalink
datapath-windows: Remove setting of replyLen to zero.
Browse files Browse the repository at this point in the history
This was one of the review comment which i forgot to address in
FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero
 as caller would have already set it.

Signed-off-by: Ankur Sharma <ankursharma@vmware.com>
Acked-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
  • Loading branch information
ankursh authored and blp committed Oct 13, 2014
1 parent c26acd5 commit 5b69dd8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions datapath-windows/ovsext/Flow.c
Expand Up @@ -269,8 +269,6 @@ OvsFlowNlCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
RtlZeroMemory(&stats, sizeof(stats));
RtlZeroMemory(&replyStats, sizeof(replyStats));

*replyLen = 0;

if (!(usrParamsCtx->outputBuffer)) {
/* No output buffer */
rc = STATUS_INVALID_BUFFER_SIZE;
Expand Down Expand Up @@ -387,8 +385,6 @@ OvsFlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,

NL_BUFFER nlBuf;

*replyLen = 0;

if (!(usrParamsCtx->outputBuffer)) {
/* No output buffer */
rc = STATUS_INVALID_BUFFER_SIZE;
Expand Down Expand Up @@ -463,8 +459,6 @@ _FlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
UINT32 keyAttrOffset = 0;
UINT32 tunnelKeyAttrOffset = 0;

*replyLen = 0;

if (usrParamsCtx->inputLength > usrParamsCtx->outputLength) {
/* Should not be the case.
* We'll be copying the flow keys back from
Expand Down

0 comments on commit 5b69dd8

Please sign in to comment.