Skip to content

Commit

Permalink
tc: Change filter error to debug once
Browse files Browse the repository at this point in the history
Also update the message to be more correct.
Before this commit if there were tc rules that are not of type
flower the log was getting filled quickyl with errors about it
and always appeared to the user when dumping flows from user space.
This commit moves the error to debug and logs it only once.

Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
  • Loading branch information
roidayan authored and horms committed Apr 11, 2018
1 parent 2f74f4f commit 722f25b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/tc.c
Expand Up @@ -952,7 +952,7 @@ parse_netlink_to_tc_flower(struct ofpbuf *reply, struct tc_flower *flower)

kind = nl_attr_get_string(ta[TCA_KIND]);
if (strcmp(kind, "flower")) {
VLOG_ERR_RL(&error_rl, "failed to parse filter: %s", kind);
VLOG_DBG_ONCE("Unsupported filter: %s", kind);
return EPROTO;
}

Expand Down

0 comments on commit 722f25b

Please sign in to comment.