Skip to content

Commit

Permalink
ovs-monitor-ipsec: Suppress "unknown %d argument" warning.
Browse files Browse the repository at this point in the history
As 'ovs-vswitchd' does not understand IPsec tunnel options, it
gives a warning message. This can be safely suppressed.

Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1906701
Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Acked-by: Flavio Leitner <fbl@sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
markdgray authored and igsilya committed Jan 5, 2021
1 parent 9505f78 commit 8397d46
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions lib/netdev-vport.c
Expand Up @@ -745,6 +745,14 @@ set_tunnel_config(struct netdev *dev_, const struct smap *args, char **errp)
goto out;
}
}
} else if (!strcmp(node->key, "remote_cert") ||
!strcmp(node->key, "remote_name") ||
!strcmp(node->key, "psk")) {
/* When configuring OVS for IPsec, these keys may be set in the
tunnel port's 'options' column. 'ovs-vswitchd' does not directly
use them, but they are read by 'ovs-monitor-ipsec'. In order to
suppress the "unknown %s argument" warning message below, we
handle them here by ignoring them. */
} else {
ds_put_format(&errors, "%s: unknown %s argument '%s'\n", name,
type, node->key);
Expand Down

0 comments on commit 8397d46

Please sign in to comment.