Skip to content

Commit

Permalink
ofproto-dpif-xlate: Stop forwarding MLD reports to group ports.
Browse files Browse the repository at this point in the history
According with rfc4541 section 2.1.1, a snooping switch
should forward membership reports only to ports with
routers attached.The current code violates the RFC
forwarding membership reports to group ports as well.
The same issue doesn't exist with IPv4.

Fixes: 06994f8 ("mcast-snooping: Add Multicast Listener Discovery support")
Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com>
Acked-by: Flavio Leitner <fbl@sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
d00273192 authored and igsilya committed Dec 21, 2020
1 parent 0dc0cee commit 9c433ab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ofproto/ofproto-dpif-xlate.c
Expand Up @@ -2607,6 +2607,7 @@ xlate_normal(struct xlate_ctx *ctx)
xlate_report(ctx, OFT_DETAIL, "MLD query, flooding");
xlate_normal_flood(ctx, in_xbundle, vlan);
}
return;
} else {
if (is_ip_local_multicast(flow, wc)) {
/* RFC4541: section 2.1.2, item 2: Packets with a dst IP
Expand Down

0 comments on commit 9c433ab

Please sign in to comment.