Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ovs-rcu: Make ovsrcu_quiesce() flush the callback event set.
On current master, the per-thread callback event set is flushed when ovsrcu_quiesce_start() is called or when the callback event set is full. For threads that only call 'ovsrcu_quiesce()' to indicate quiescient state, their callback event set will not be flushed for execution until the set is full. And this could take a very long time. Theoretically, this should not be an issue, since rcu postponed callback events should only free the old version of objects. However, current ovs does not follow this rule, and some callback events include other activities like unregistering the netdev from global name-netdev map. The delay of unregistering the netdev (by threads that only calls ovsrcu_quiesce()) will prevent the recreate of same netdev indefinitely. As a short-term workaround, this commit makes every call to ovsrcu_quiesce() flush the callback event set. In the long run, there will be a refactor of the use of ovs-rcu module, in which all callback events only free the old version of objects. Signed-off-by: Alex Wang <alexw@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
- Loading branch information