Skip to content

Commit

Permalink
dpif: Remove unused 'get_max_ports' from provider interface.
Browse files Browse the repository at this point in the history
Nothing ever called this function.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
  • Loading branch information
blp committed Jan 9, 2014
1 parent 98045ed commit 9e50269
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
7 changes: 0 additions & 7 deletions lib/dpif-linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -673,12 +673,6 @@ dpif_linux_port_query_by_name(const struct dpif *dpif, const char *devname,
return dpif_linux_port_query__(dpif, 0, devname, dpif_port);
}

static uint32_t
dpif_linux_get_max_ports(const struct dpif *dpif OVS_UNUSED)
{
return MAX_PORTS;
}

static uint32_t
dpif_linux_port_get_pid(const struct dpif *dpif_, odp_port_t port_no)
{
Expand Down Expand Up @@ -1620,7 +1614,6 @@ const struct dpif_class dpif_linux_class = {
dpif_linux_port_del,
dpif_linux_port_query_by_number,
dpif_linux_port_query_by_name,
dpif_linux_get_max_ports,
dpif_linux_port_get_pid,
dpif_linux_port_dump_start,
dpif_linux_port_dump_next,
Expand Down
7 changes: 0 additions & 7 deletions lib/dpif-netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,12 +628,6 @@ dpif_netdev_port_query_by_name(const struct dpif *dpif, const char *devname,
return error;
}

static uint32_t
dpif_netdev_get_max_ports(const struct dpif *dpif OVS_UNUSED)
{
return MAX_PORTS;
}

static void
dp_netdev_free_flow(struct dp_netdev *dp, struct dp_netdev_flow *netdev_flow)
{
Expand Down Expand Up @@ -1464,7 +1458,6 @@ const struct dpif_class dpif_netdev_class = {
dpif_netdev_port_del,
dpif_netdev_port_query_by_number,
dpif_netdev_port_query_by_name,
dpif_netdev_get_max_ports,
NULL, /* port_get_pid */
dpif_netdev_port_dump_start,
dpif_netdev_port_dump_next,
Expand Down
4 changes: 0 additions & 4 deletions lib/dpif-provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,6 @@ struct dpif_class {
int (*port_query_by_name)(const struct dpif *dpif, const char *devname,
struct dpif_port *port);

/* Returns one greater than the largest port number accepted in flow
* actions. */
uint32_t (*get_max_ports)(const struct dpif *dpif);

/* Returns the Netlink PID value to supply in OVS_ACTION_ATTR_USERSPACE
* actions as the OVS_USERSPACE_ATTR_PID attribute's value, for use in
* flows whose packets arrived on port 'port_no'.
Expand Down

0 comments on commit 9e50269

Please sign in to comment.