datapath-windows: Remove Strsafe usage from datapath

The removal is mandatory to use the VStudio 2013 static code analyzer. The only function that was used from the include is: 'StringCbLengthA'. We were not checking the result of that function, nor will the 'vportGet->name' exceed the 'OVS_MAX_PORT_NAME_LENGTH' limitation. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Acked-By: Anand Kumar <kumaranand@vmware.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
openvswitch · May 25, 2017 · ad91a8e · ad91a8e
1 parent c052756
commit ad91a8e
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
@@ -40,7 +40,6 @@
 #include <intsafe.h>
 #include <ntintsafe.h>
 #include <ntstrsafe.h>
-#include <Strsafe.h>
 
 #ifdef OVS_DBG_MOD
 #undef OVS_DBG_MOD

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
@@ -1618,15 +1618,13 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet,
                    POVS_VPORT_EXT_INFO extInfo)
 {
     POVS_VPORT_ENTRY vport;
-    size_t len;
     LOCK_STATE_EX lockState;
     NTSTATUS status = STATUS_SUCCESS;
     BOOLEAN doConvert = FALSE;
 
     RtlZeroMemory(extInfo, sizeof (POVS_VPORT_EXT_INFO));
     NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, &lockState, 0);
     if (vportGet->portNo == 0) {
-        StringCbLengthA(vportGet->name, OVS_MAX_PORT_NAME_LENGTH - 1, &len);
         vport = OvsFindVportByHvNameA(gOvsSwitchContext, vportGet->name);
         if (vport == NULL) {
             /* If the port is not a Hyper-V port and it has been added earlier,

diff --git a/datapath-windows/ovsext/precomp.h b/datapath-windows/ovsext/precomp.h
@@ -19,7 +19,6 @@
 #include <intsafe.h>
 #include <ntintsafe.h>
 #include <ntstrsafe.h>
-#include <Strsafe.h>
 
 #include "Types.h"