Skip to content

Commit

Permalink
python: Stop using xrange().
Browse files Browse the repository at this point in the history
Python 2 had range() and xrange().  xrange() is more efficient, but
behaves differently so range() was retained for compatibility.  Python 3
only has range() and it behaves like Python 2's xrange().

Remove explicit use of xrange() and use six.moves.range() to
make sure we're using xrange() from Python 2 or range() from Python 3.

Signed-off-by: Russell Bryant <russell@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
  • Loading branch information
russellb committed Jan 20, 2016
1 parent 73eb682 commit b3ac294
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 2 deletions.
1 change: 1 addition & 0 deletions debian/ovs-monitor-ipsec
Expand Up @@ -39,6 +39,7 @@ import ovs.db.idl
import ovs.unixctl
import ovs.unixctl.server
import ovs.vlog
from six.moves import range

vlog = ovs.vlog.Vlog("ovs-monitor-ipsec")
root_prefix = '' # Prefix for absolute file names, for testing.
Expand Down
2 changes: 2 additions & 0 deletions python/ovs/json.py
Expand Up @@ -16,6 +16,8 @@
import StringIO
import sys

from six.moves import range

__pychecker__ = 'no-stringiter'

escapes = {ord('"'): u"\\\"",
Expand Down
2 changes: 2 additions & 0 deletions python/ovs/ovsuuid.py
Expand Up @@ -15,6 +15,8 @@
import re
import uuid

from six.moves import range

from ovs.db import error
import ovs.db.parser

Expand Down
4 changes: 3 additions & 1 deletion python/ovs/socket_util.py
Expand Up @@ -19,6 +19,8 @@
import socket
import sys

from six.moves import range

import ovs.fatal_signal
import ovs.poller
import ovs.vlog
Expand All @@ -32,7 +34,7 @@ def make_short_name(long_name):
long_name = os.path.abspath(long_name)
long_dirname = os.path.dirname(long_name)
tmpdir = os.getenv('TMPDIR', '/tmp')
for x in xrange(0, 1000):
for x in range(0, 1000):
link_name = \
'%s/ovs-un-py-%d-%d' % (tmpdir, random.randint(0, 10000), x)
try:
Expand Down
2 changes: 2 additions & 0 deletions python/ovs/unixctl/server.py
Expand Up @@ -17,6 +17,8 @@
import os
import types

from six.moves import range

import ovs.dirs
import ovs.jsonrpc
import ovs.stream
Expand Down
2 changes: 2 additions & 0 deletions python/ovs/vlog.py
Expand Up @@ -22,6 +22,8 @@
import sys
import threading

from six.moves import range

import ovs.dirs
import ovs.unixctl
import ovs.util
Expand Down
1 change: 1 addition & 0 deletions python/ovstest/util.py
Expand Up @@ -26,6 +26,7 @@
import subprocess
import re

from six.moves import range
import six.moves.xmlrpc_client


Expand Down
3 changes: 2 additions & 1 deletion tests/test-vlog.py
Expand Up @@ -15,10 +15,11 @@
import argparse

import ovs.vlog
from six.moves import range


def main():
modules = [ovs.vlog.Vlog("module_%d" % i) for i in xrange(3)]
modules = [ovs.vlog.Vlog("module_%d" % i) for i in range(3)]

parser = argparse.ArgumentParser(description="Vlog Module Tester")
ovs.vlog.add_args(parser)
Expand Down
1 change: 1 addition & 0 deletions vtep/ovs-vtep
Expand Up @@ -29,6 +29,7 @@ import ovs.util
import ovs.daemon
import ovs.unixctl.server
import ovs.vlog
from six.moves import range


VERSION = "0.99"
Expand Down

0 comments on commit b3ac294

Please sign in to comment.