Skip to content

Commit

Permalink
datapath-windows: remove extract flow in OvsDoRecirc()
Browse files Browse the repository at this point in the history
It is not necessary to do a flow extract in OvsDoRecirc().
In fact, doing it would overwrite the tunnel key within
'key'. So, let's remove the call.

Signed-off-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Sairam Venugopal <vsairam@vmware.com>
Co-Authored-by: Sairam Venugopal <vsairam@vmware.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Acked-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
Signed-off-by: Joe Stringer <joe@ovn.org>
  • Loading branch information
2 people authored and joestringer committed May 25, 2016
1 parent 3871d4f commit bfac271
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions datapath-windows/ovsext/Actions.c
Expand Up @@ -1989,15 +1989,6 @@ OvsDoRecirc(POVS_SWITCH_CONTEXT switchContext,
NET_BUFFER_LIST_SWITCH_FORWARDING_DETAIL(curNbl),
completionList, layers, TRUE);

status = OvsExtractFlow(ovsFwdCtx.curNbl, ovsFwdCtx.srcVportNo, key,
&ovsFwdCtx.layers, NULL);
if (status != NDIS_STATUS_SUCCESS) {
OvsCompleteNBLForwardingCtx(&ovsFwdCtx,
L"OVS-Dropped due to extract flow failure");
ovsActionStats.failedFlowMiss++;
return NDIS_STATUS_FAILURE;
}

flow = OvsLookupFlow(&ovsFwdCtx.switchContext->datapath, key, &hash, FALSE);
if (flow) {
UINT32 level = OvsDeferredActionsLevelGet();
Expand Down

0 comments on commit bfac271

Please sign in to comment.