Skip to content

Commit

Permalink
meta-flow: fix a typo in "MPLS Bottom of Stack Field" paragraph.
Browse files Browse the repository at this point in the history
In the ovs-fields.7 manual page, the "MPLS Bottom of Stack Field" paragraph
says:
 * When mpls_bos is 1, there is another MPLS label following this one,
   so the Ethertype passed to pop_mpls should be an MPLS Ethertype. [...]

 * When mpls_bos is 0, this MPLS label is the last one, so the Ethertype
   passed to pop_mpls should be a non-MPLS Ethertype such as IPv4. [...]

The values 0 and 1 have been swapped: when BOS is 1,
then no more label stack entries follows.

Fixes: 96fee5e ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.")
Reported-at: https://bugzilla.redhat.com/1842032
Reported-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
Acked-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
  • Loading branch information
drizzt authored and igsilya committed Aug 26, 2020
1 parent a2ab306 commit cc334a6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/meta-flow.xml
Expand Up @@ -3920,18 +3920,18 @@ r r c c c.

<ul>
<li>
When <ref field="mpls_bos"/> is 1, there is another MPLS label
When <ref field="mpls_bos"/> is 0, there is another MPLS label
following this one, so the Ethertype passed to <code>pop_mpls</code>
should be an MPLS Ethertype. For example: <code>table=0,
dl_type=0x8847, mpls_bos=1, actions=pop_mpls:0x8847,
dl_type=0x8847, mpls_bos=0, actions=pop_mpls:0x8847,
goto_table:1</code>
</li>

<li>
When <ref field="mpls_bos"/> is 0, this MPLS label is the last one,
When <ref field="mpls_bos"/> is 1, this MPLS label is the last one,
so the Ethertype passed to <code>pop_mpls</code> should be a non-MPLS
Ethertype such as IPv4. For example: <code>table=1, dl_type=0x8847,
mpls_bos=0, actions=pop_mpls:0x0800, goto_table:2</code>
mpls_bos=1, actions=pop_mpls:0x0800, goto_table:2</code>
</li>
</ul>
</field>
Expand Down

0 comments on commit cc334a6

Please sign in to comment.