Skip to content

Commit

Permalink
datapath-windows: Solved BSOD when handling flows
Browse files Browse the repository at this point in the history
OvsPrepareFlow() returns an error only when the new flow allocation
fails. In this case HandleFlowPut() should return error without trying
to free the flow, thus avoiding the BSOD.

Signed-off-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-at: openvswitch/ovs-issues#91
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
  • Loading branch information
svinturis authored and blp committed Jul 1, 2015
1 parent 35303d7 commit d30fa82
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion datapath-windows/ovsext/Flow.c
Expand Up @@ -2163,7 +2163,6 @@ HandleFlowPut(OvsFlowPut *put,

status = OvsPrepareFlow(&KernelFlow, put, hash);
if (status != STATUS_SUCCESS) {
FreeFlow(KernelFlow);
return STATUS_UNSUCCESSFUL;
}

Expand Down

0 comments on commit d30fa82

Please sign in to comment.