ovsdb: Enable memory trimming after compaction by default.

Memory trimming was introduced in OVS 2.15 and didn't cause any issues in production environments since then, while allowing ovsdb-sever to consume a lot less memory in high scale OVN deployments. Enabling by default to make it easier to use. Acked-by: Dumitru Ceara <dceara@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
openvswitch · Jul 12, 2022 · e773140 · e773140
1 parent fe7382d
commit e773140
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -21,6 +21,9 @@ Post-v2.17.0
        configuration in a clustered databse independently for each server.
        E.g. for listening on unique addresses.  See the ovsdb.local-config.5
        manpage for schema details.
+     * Returning unused memory to the OS after the database compaction is now
+       enabled by default.  Use 'ovsdb-server/memory-trim-on-compaction off'
+       unixctl command to disable.
    - OVSDB-IDL:
      * New monitor mode flag, OVSDB_IDL_WRITE_CHANGED_ONLY, allowing
        applications to relax atomicity requirements when dealing with

diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
@@ -80,7 +80,7 @@ static char *ssl_ciphers;
 static bool bootstrap_ca_cert;
 
 /* Try to reclaim heap memory back to system after DB compaction. */
-static bool trim_memory = false;
+static bool trim_memory = true;
 
 static unixctl_cb_func ovsdb_server_exit;
 static unixctl_cb_func ovsdb_server_compact;