Fix 'ovsdb-client needs-conversion' to access remote server #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The change looks fine. Also, please, add the problem description to the commit message itself. |
roytman
force-pushed
the
needs-conversion
branch
2 times, most recently
from
caee2af
to
ea96d8a
Compare
|
Hi Ilya, thanks for the review. |
roytman
force-pushed
the
needs-conversion
branch
from
ea96d8a
to
2e4a499
Compare
igsilya
reviewed
Feb 17, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
roytman
force-pushed
the
needs-conversion
branch
from
2e4a499
to
79981e6
Compare
|
hi @igsilya, should I do something else here? |
|
@roytman, the change looks good to me, I'll apply it later today. |
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
igsilya
pushed a commit
to igsilya/ovs
that referenced
this pull request
Feb 19, 2021
When you try to specify `SERVER` to the 'ovsdb-client needs-conversion' command, it interprets the `SERVER` parameter as the path to the schema and returns an error. This PR fixes it. Fixes: 1b1d2e6 ("ovsdb: Introduce experimental support for clustered databases.") Submitted-at: openvswitch#347 Signed-off-by: Alexey Roytman <roytman@il.ibm.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to specify
SERVERit interprets the parameter as the path to the schema.`ovsdb-client needs-conversion unix:/var/run/openvswitch/db.sock ./_server.ovsschema
ovsdb-client: failed to read schema: "unix:/var/run/openvswitch/db.sock" could not be read as JSON (error opening "unix:/var/run/openvswitch/db.sock": No such file or directory)`
This PR fixes it.
Signed-off-by: Alexey Roytman roytman@il.ibm.com