Windows build in github action #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script generates bash compatible environment variables from Windows environment variables.
fixed name of logs in github action "upload logs on failure"
Improvements of Windows Build: - run only one test for Win 10 in PRs - disable tests (takes to long currently and a lot of them are failing) - make sure that VS link ist used and not link from msys
aserdean
reviewed
Oct 7, 2021
|
|
||
| OPTS="${EXTRA_OPTS} ${OPTS} $*" | ||
| configure_ovs $OPTS | ||
| make -j4 || { cat config.log; exit 1; } |
There was a problem hiding this comment.
Please change to make -j so it will use as many threads as the container / VM has
| make -j4 || { cat config.log; exit 1; } | ||
|
|
||
| if [ "$TESTSUITE" ]; then | ||
| if ! make check TESTSUITEFLAGS=-j8 RECHECK=yes; then |
There was a problem hiding this comment.
In this case we need to drop TESTSUITEFLAGS=-j8
| OPTS: --prefix=C:/openvswitch/usr --localstatedir=C:/openvswitch/var --sysconfdir=C:/openvswitch/etc ${{ matrix.opts }} | ||
| TESTSUITE: ${{ matrix.testsuite }} | ||
|
|
||
| # linking on latest VS 2019 don't work, most propably due to a VS 2019 issue since VS 16.10 |
|
Thank you for the PR @fw2568. Can you please squash all the commits and add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a github action to build ovs for windows.
As discussed in openvswitch/ovs-issues#209 use is currently limited as tests cannot be run for windows for a PR and PR requests are not the primary workflow to submit changes to ovs.