-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add some rules optimizations (mostly rejection flags/commands).
- Loading branch information
1 parent
059d4e6
commit 15163f4
Showing
1 changed file
with
111 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15163f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magnumripper Have you confirmed this produces the exact same lists of candidate passwords that it did before, on large and weird enough input and with different settings (per-hash-type flags, max lengths)?
I'm concerned e.g. the added
-c
before lines with[lc]
will probably miss candidate passwords that we would have produced previously if there's no corresponding line working on the non-case-altered input word. Maybe you meant to add the-c
conditionally to one of thel
orc
. I mean lines like:where you could have needed to use my approach of:
15163f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test it and verify but I probably forgot about the FMT_CASE thing. I'll hack
-stdout
to announce itself as case insignificant and see what happens.I opened #3517 for these potential issues.