-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a new release soon as the previous one has Python 3 compatibility issues and known-fixed bugs #4564
Comments
I would highly appreciate to get a guicy release :P |
@noraj Do you want to help us make that release sooner rather than later? We need to at least bring |
@noraj Right. The task is to go over the commits made since 1.9.0-jumbo-1 and add to |
I've just removed most issues from the "Definitely 1.9.0-jumbo-2" milestone. Most of those went to the "Potentially 1.9.0-jumbo-2" milestone, some were removed from milestones altogether. Some of the issues only need more review to determine that we can close them or don't have to work on them before the release. Some need actual work. |
This task is now #4570. We also had #3979 titled after for the upcoming release, but it has some "irrelevant" stuff said on it (on general and longer-term planning rather than on what really needs to be done for the release). So I suggest we use this new issue for planning the release from now on. |
Another example of a "bug" fixed in bleeding-jumbo:
|
@claudioandre-br No, this wasn't anything we fixed - rather, the line wrapping prevented you from testing the same thing that the question on john-users was about. Anyway, let's not collect supposedly fixed issues in here. (If you feel anything like this should be added to |
Since on OpenWall website the latest john package is still the one with this issue, a new working official release with these fixes will be released or not? Or we should use the bleeding version forever? I see that the latest version on the website is on 2019... |
@D3vil0p3r A new release will be made. Hopefully soon, but no specific date has been set. We should be making releases more often. Unfortunately, releases were also infrequent before - e.g., 1.8.0-jumbo-1 in December 2014 followed by 1.9.0-jumbo-1 only in May 2019. |
Thank you for the answer @solardiz ! The important aspect for me, even if there is no a date, in the future could be a new release in order to fix the described issue with the latest "stable" official release. Thank you again ^^ |
Please make a new release. Your latest release does not compile on Apple Silicon Macs. You have already fixed this problem in the code years ago (#4585) but users continue to encounter it as they attempt to use your latest release. |
Your latest release does not compile on Intel Macs either due to multiple definition of symbols, another problem you fixed in the repository years ago (#4258). |
Another bug already been fixed on bleeding jumbo
|
I've made a fix locally by using the hex() method instead of encode("hex"): saltstr = data[salt_offset:salt_offset+salt_length].hex() I believe this change should resolve the issue. However, I'm not sure where in the codebase this change should be made to reflect it correctly. Any guidance on this would be appreciated. |
@prbhtkumr My understanding is that all bugs discussed on this issue are already fixed in this repo. The only reason you ran into those bugs is you're using an older version. We appreciate your willingness to contribute fixes, but for that please start by using our latest code from here to find/fix bugs that still exist. Thank you! |
Early and OftenThinking out loud:
Therefore (or because of this):
[1] |
I don't mind us starting to create 1.9.1, etc. releases on GitHub while preparing for a 2.0.0 release from Openwall, but I also don't intend to spend my time on it currently. Claudio, is this something you'd like to start doing? |
I don't mind doing that. But I simply don't have the power to do it. Using a GUI or CLI takes more than I can do. The release commit itself is very simple, but I can create a PR. I won't dwell too much on release notes and things like that. "This is a bug fix, renovate, and update release intended to provide a modernized version to end users and packagers. "Early and Often". BTW: I'll pick a commit, change the release ID and such. And that's it. After that, I will go back to using the bleeding name. GitHub itself will be the advertising platform. Just to be clear, only one thing bothers me: it is #3517. It seems like a change in behavior that is not clear whether it is right or wrong. |
Same kind of error as for #3345.
It is preset in 1.9.0-jumbo-1 git tag:
john/run/ssh2john.py
Line 103 in a16c8a7
But it's fixed in bleeding-jumbo git tag:
john/run/ssh2john.py
Lines 107 to 114 in 07c0f3c
tag 1.9.0-jumbo is from May 14, 2019.
So releasing a new version will help fix that bug in distro packages that are mostly using python 3.9 nowadays.
System configuration
Workaround for distro packager waiting for the new release
ArchLinux FS#69545
The text was updated successfully, but these errors were encountered: