Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver a new tarball release #5494

Open
wants to merge 2 commits into
base: bleeding-jumbo
Choose a base branch
from

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Jun 10, 2024

Define RELEASE_BUILD and make a short announcement about it.


Some testing is neeeded, but, IMO, this is enough. It is a tarball release.


========== [EDITED] ==========

Note

My vote is to use 1.10.0-ce. So, tag it as v1.10.0-ce.


Still missing something like this:

$ git diff
diff --git a/README.md b/README.md
index d14b3c0bc0..d51514709b 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@
 [![Downloads](https://img.shields.io/badge/Download-Windows%20Build-blue.svg)](https://github.com/openwall/john-packages/releases)
 [![License](https://img.shields.io/badge/License-GPL%20v2%2B-blue.svg)](https://github.com/openwall/john/blob/bleeding-jumbo/doc/LICENSE)
 ![GitHub commit activity](https://img.shields.io/github/commit-activity/m/openwall/john?color=yellow)
-![GitHub commits since tagged version](https://img.shields.io/github/commits-since/openwall/john/1.9.0-Jumbo-1?color=brown)
+![GitHub commits since tagged version](https://img.shields.io/github/commits-since/openwall/john/v1.10.0-ce?color=brown)
 
 John the Ripper
 ===============

@claudioandre-br claudioandre-br added the RFC / discussion Help or comments wanted label Jun 10, 2024
@claudioandre-br claudioandre-br changed the title Deliver a new 1.9.1-dev tarball file Deliver a new release Jun 10, 2024
@claudioandre-br
Copy link
Member Author

$ ../run/john
John the Ripper 1.9.1-dev c5e2455d35 2024-06-10 OMP [linux-gnu 64-bit x86_64 AVX2 AC]
Copyright (c) 1996-2024 by Solar Designer and others
Homepage: https://www.openwall.com/john/

Usage: john [OPTIONS] [PASSWORD-FILES]

Use --help to list all available options.
$ ../run/john --list=build-info
Version: 1.9.1-dev c5e2455d35 2024-06-10
Build: linux-gnu 64-bit x86_64 AVX2 AC OMP OPENCL
SIMD: AVX2, interleaving: MD4:3 MD5:3 SHA1:1 SHA256:1 SHA512:1
CPU tests: AVX2
$JOHN is ../run/
[...]

@claudioandre-br
Copy link
Member Author

I deleted and restored the branch.

@solardiz
Copy link
Member

I'll need to think of what to do with the 3 change logs we have. So far, CHANGES was for core only, so it's weird to start talking about jumbo in there. I think I'd rather rename it to CHANGES-core and add a note that it's preserved for historical reasons and that the current one is NEWS. We also have CHANGES-jumbo, which I guess we should either update or remove.

@claudioandre-br
Copy link
Member Author

I moved the text to RELEASE-NOTES.md

I also added the revert commit [1] just to document the whole process.

[1] We can add a tag to an older commit in git, but, do not merge unless you want to do so.

Define RELEASE_BUILD and make a short announcement about it.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
Back to the Future, a.k.a. drop the release macros. We're now back to
bleeding Jumbo.

Undefine RELEASE_BUILD.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
@claudioandre-br
Copy link
Member Author

So, if I got it right, I should use 1.9.1-ce. Amending the PR.


In reality, the tag is not strictly necessary, but it would be weird not to tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC / discussion Help or comments wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a new release soon as the previous one has Python 3 compatibility issues and known-fixed bugs
2 participants