Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a misleading indentation compiler warning #2177

Merged
merged 1 commit into from Jul 19, 2016
Merged

Fix a misleading indentation compiler warning #2177

merged 1 commit into from Jul 19, 2016

Conversation

kholia
Copy link
Member

@kholia kholia commented Jul 19, 2016

@magnumripper the following seems to be a valid warning, simply de-indenting the "if block" should get rid of this warning.

$ gcc --version
gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3)
Copyright (C) 2016 Free Software Foundation, Inc.
$ make
...
gcc ...options.c -o options.o
options.c: In function ‘opt_init’:
options.c:706:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if (!two_values)
     ^~
options.c:708:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
      if (negative && options.loader.min_cost[i] == 0) {
      ^~

I don't actually know what this code does, so a careful review is needed.

@magnumripper magnumripper merged commit 3e16257 into openwall:bleeding-jumbo Jul 19, 2016
@kholia kholia deleted the indentation-warning-fix branch July 23, 2016 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants