Apple M1 (and likely some other arm64) patches #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
magnumripper
changed the title
|
Tested for regression on Raspberry Pi, 32-bit and 64-bit. No problem seen - on the contrary, both got the RAR format again, which was disabled in 2017 by ddeabc6. |
…m64) It would end up picking arm32le.h due to flaws in the detecting macro. See openwall#4585
This allows the RAR format to build, where applicable. See openwall#4585
MacOS native (clang) gcc wouldn't allow rotations larger than width so we simply mask the argument correctly. Closes openwall#4585
solardiz
approved these changes
Mar 7, 2021
| [[#include <arm_neon.h> | ||
| #include <stdio.h> | ||
| extern void exit(int); | ||
| int main(){uint32x4_t t;*((long*)&t)=1;t=veorq_u32(t,t);if((*(unsigned*)&t)==88)printf(".");exit(0);}]] |
There was a problem hiding this comment.
It's not great that we have C aliasing violations in these configure test programs. I recall us discussing this before (for some other arch), but I don't recall what the outcome of the discussion was.
There was a problem hiding this comment.
While at that we could drop the need for stdio and just end with a calculated exitcode, expected 0 - the current test of "88" is most everywhere and doesn't test correctness, we only look for build ok/fail and run ok/segfault. Let's make a separate issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4585