RAR formats: Reject old archives #5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have "unknown" KDF and encryption, and no salt. We could work it out by examining public unrar source code, but such archives are so rare I'm not sure we'll ever bother. Closes openwall#5271
|
Should we ideally also do such rejection in the format? For "hashes" generated by |
I added that at first but rejected it. The only thing the formats can detect is an all-zero salt and I'm not sure that could not happen (and be valid) in some other remote cases. The formats could/should emit a warning about it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have "unknown" KDF and encryption, and no salt. We could work it out by examining public unrar source code, but such archives are so rare I'm not sure we'll ever bother.
Closes #5271 - see also #5273