descrypt-opencl and lm-opencl fixes, argon2-opencl cleanup and optimization #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively reverts the problematic hunks from 8026942 and d7a8a22. Fixes openwall#5236
This partially and conditionally reverts b5bab6c
|
To review actual changes in commits with mostly whitespace changes, add |
|
@alainesp This mostly cleans up your code, you might want to take a look. There was an awful mix of spaces and tabs in your files, now mostly changed to tabs only. There are also a few functional changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5236, cleans up and slightly speeds up argon2-opencl, and switches other kernels to use shared rotate macros (may affect performance of sha256crypt-opencl and sha512crypt-opencl, may hide/expose bugs).