Fixes: #462: In com.android.identity.wallet.transfer.Communication se…

…ndResponse If `closeAfterSending` is true, only close the connection after we know the `deviceResponse` payload have been sent.
openwallet-foundation-labs · Jan 30, 2024 · 488360d · 488360d
1 parent 06fe0d3
commit 488360d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 22 deletions.
diff --git a/appholder/src/main/java/com/android/identity/wallet/fragment/TransferDocumentFragment.kt b/appholder/src/main/java/com/android/identity/wallet/fragment/TransferDocumentFragment.kt
@@ -163,13 +163,13 @@ class TransferDocumentFragment : Fragment() {
     private fun onTransferDisconnected() {
         log("Disconnected")
         hideButtons()
-        TransferManager.getInstance(requireContext()).disconnect()
+        TransferManager.getInstance(requireContext()).disconnect(true)
     }
 
     private fun onTransferError() {
         Toast.makeText(requireContext(), "An error occurred.", Toast.LENGTH_SHORT).show()
         hideButtons()
-        TransferManager.getInstance(requireContext()).disconnect()
+        TransferManager.getInstance(requireContext()).disconnect(true)
     }
 
     private fun hideButtons() {

diff --git a/appholder/src/main/java/com/android/identity/wallet/transfer/Communication.kt b/appholder/src/main/java/com/android/identity/wallet/transfer/Communication.kt
@@ -45,21 +45,16 @@ class Communication private constructor(
             if (progress == max) {
                 log("Completed...")
             }
+            if (progress == max && closeAfterSending) {
+                deviceRetrievalHelper?.disconnect()
+            }
         }
-        if (closeAfterSending) {
-            deviceRetrievalHelper?.sendDeviceResponse(
-                deviceResponse,
-                OptionalLong.of(Constants.SESSION_DATA_STATUS_SESSION_TERMINATION),
-                progressListener,
-                context.mainExecutor())
-            deviceRetrievalHelper?.disconnect()
-        } else {
-            deviceRetrievalHelper?.sendDeviceResponse(
-                deviceResponse,
-                OptionalLong.empty(),
-                progressListener,
-                context.mainExecutor())
-        }
+
+        deviceRetrievalHelper?.sendDeviceResponse(
+            deviceResponse,
+            OptionalLong.of(Constants.SESSION_DATA_STATUS_SESSION_TERMINATION),
+            progressListener,
+            context.mainExecutor())
     }
 
     fun stopPresentation(

diff --git a/appholder/src/main/java/com/android/identity/wallet/transfer/TransferManager.kt b/appholder/src/main/java/com/android/identity/wallet/transfer/TransferManager.kt
@@ -244,11 +244,13 @@ class TransferManager private constructor(private val context: Context) {
             sendSessionTerminationMessage,
             useTransportSpecificSessionTermination
         )
-        disconnect()
+        disconnect(true)
     }
 
-    fun disconnect() {
-        communication.disconnect()
+    fun disconnect(disconnectCommunication: Boolean) {
+        if (disconnectCommunication) {
+            communication.disconnect()
+        }
         qrCommunicationSetup?.close()
         transferStatusLd = MutableLiveData<TransferStatus>()
         destroy()
@@ -262,9 +264,7 @@ class TransferManager private constructor(private val context: Context) {
 
     fun sendResponse(deviceResponse: ByteArray, closeAfterSending: Boolean) {
         communication.sendResponse(deviceResponse, closeAfterSending)
-        if (closeAfterSending) {
-            disconnect()
-        }
+        disconnect(!closeAfterSending)
     }
 
     fun readDocumentEntries(documentName: String): DocumentElements {