Send message with status 10 if unable to decrypt message from reader. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior is that we would just terminate the session. With this change before session termination we send a message with no data and status 10 which according to 18013-5 Table 20 means "Error: session decryption". It's not clear the standard actually requires an mdoc to do this but unfortunately it's something that certain test suites will check for. Add new unit test to check the behavior and introduce symbolic constants instead of hardcoding 10 and 20. Test: New unit test and all unit tests pass. Test: Manually tested reference apps on two Pixel devices. Issue: 115
divegeek
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior is that we would just terminate the session. With this change before session termination we send a message with no data and status 10 which according to 18013-5 Table 20 means "Error: session decryption".
It's not clear the standard actually requires an mdoc to do this but unfortunately it's something that certain test suites will check for.
Add new unit test to check the behavior and introduce symbolic constants instead of hardcoding 10 and 20.
Test: New unit test and all unit tests pass.
Test: Manually tested reference apps on two Pixel devices.
Issue: 115