Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleApplicationData: Don't call listener during construction. #356

Merged
merged 1 commit into from
Aug 16, 2023
Merged

SimpleApplicationData: Don't call listener during construction. #356

merged 1 commit into from
Aug 16, 2023

Conversation

davidz25
Copy link
Contributor

Test: New unit test and all unit tests pass.

@davidz25
SimpleApplicationData: Don't call listener during construction.
f65a159 
Test: New unit test and all unit tests pass.
suzannajiwani
suzannajiwani approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@suzannajiwani suzannajiwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point about unwanted listener calls in the decode function, thanks for the fix

@davidz25 davidz25 merged commit c035ca3 into master Aug 16, 2023
5 checks passed
@davidz25 davidz25 deleted the simple-application-data-dont-call-listener-during-construction branch August 16, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzannajiwani suzannajiwani suzannajiwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidz25 @suzannajiwani