type: remove rsa type in jwk

[lukasjhan]

I accidentally forgot to remove the rsa type.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (38ffb3c) to head (3a4207f).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next     #136      +/-   ##
==========================================
- Coverage   97.41%   97.41%   -0.01%     
==========================================
  Files          23       23              
  Lines        1899     1898       -1     
  Branches      273      273              
==========================================
- Hits         1850     1849       -1     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[berendsliedrecht]

What was the reason for removing rsa here?

[lukasjhan]

@berendsliedrecht We discussed this issue in #130. I thought @cre8 removed and approved it but It was not actually removed, So I opened this PR

[lukasjhan]

In case we add the rsa type, we just need to add:

interface RsaOtherPrimesInfo {
  d?: string;
  r?: string;
  t?: string;
}

[berendsliedrecht]

Ahh okay, yeah that makes sense! If we fully want to delete it would should also get rid of the n and e fields. I don't think they are used by any other algo, but they are the main components for RSA keys.

[lukasjhan]

Ahh okay, yeah that makes sense! If we fully want to delete it would should also get rid of the n and e fields. I don't think they are used by any other algo, but they are the main components for RSA keys.

Oh I see, I'll prepare PR for that :)

[cre8]

I think we could use the definition from the dom.lib.ts and just copy it. Would this solve all the edge cases?

https://github.com/microsoft/TypeScript/blob/main/src/lib/dom.generated.d.ts#L689

[lukasjhan]

I think we could use the definition from the dom.lib.ts and just copy it. Would this solve all the edge cases?

@cre8 Yeah I used that one, but we decided to remove the rsa-related part in #130. If it is okay to add it again, should we change it to add it?

[cre8]

I would add the fields again. Just because some organisation say RSA usage is not safe anymore, it is still used out there ;)

With my comments on 130 I intended that we have just the Jsonwebkey interface, but inside it all attributes to cover different keys like in the lib.dom.ts

[lukasjhan]

@cre8 @berendsliedrecht I opened a PR for restoring rsa field in JWK. #137