feat: remove explicit headerShown value in onboarding stack #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OPS <ops@Mostafas-MacBook-Pro.local>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 171 171
Lines 5466 5466
Branches 1571 1571
=======================================
Hits 3394 3394
Misses 2048 2048
Partials 24 24 ☔ View full report in Codecov by Sentry. |
cvarjao
changed the title
jleach
changed the title
|
Closing this PR in favour of #1079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove the explicit value of "headerShown" in onboarding stack in favour of global screen options default value which is "true" by default
Related Issues
Signed-off-byline (we use the DCO GitHub app to enforce this);